Skip to content

Upgrade clusters keeper service (Pydantic v2) #6519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Oct 14, 2024
Merged

Upgrade clusters keeper service (Pydantic v2) #6519

merged 13 commits into from
Oct 14, 2024

Conversation

@giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Oct 11, 2024 •
edited
Loading

What do these changes do?

Upgrade the cluster keeper service to Pydantic v2.

Related issue/s

How to test

Dev-ops checklist

@giancarloromeo giancarloromeo added the t:maintenance Some planned maintenance work label Oct 11, 2024
@giancarloromeo giancarloromeo added this to the MartinKippenberger milestone Oct 11, 2024
@giancarloromeo giancarloromeo self-assigned this Oct 11, 2024
@giancarloromeo giancarloromeo changed the title WIP: Upgrade cluster keeper service (Pydantic v2) WIP: Upgrade clusters keeper service (Pydantic v2) Oct 11, 2024
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov
Copy link

codecov bot commented Oct 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (pydantic_v2_migration@329b00d). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##             pydantic_v2_migration   #6519   +/-   ##
=======================================================
  Coverage                         ?   98.9%           
=======================================================
  Files                            ?      23           
  Lines                            ?     698           
  Branches                         ?       0           
=======================================================
  Hits                             ?     691           
  Misses                           ?       7           
  Partials                         ?       0
Flag Coverage Δ
unittests 98.9% <100.0%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...eeper/src/simcore_service_clusters_keeper/_meta.py 100.0% <100.0%> (ø)
...imcore_service_clusters_keeper/core/application.py 100.0% <100.0%> (ø)
...src/simcore_service_clusters_keeper/core/errors.py 100.0% <100.0%> (ø)
...c/simcore_service_clusters_keeper/core/settings.py 100.0% <100.0%> (ø)
...lusters_keeper/modules/clusters_management_core.py 100.0% <100.0%> (ø)
...rc/simcore_service_clusters_keeper/modules/dask.py 97.1% <ø> (ø)
.../simcore_service_clusters_keeper/utils/clusters.py 100.0% <ø> (ø)
.../src/simcore_service_clusters_keeper/utils/dask.py 100.0% <100.0%> (ø)
...r/src/simcore_service_clusters_keeper/utils/ec2.py 100.0% <100.0%> (ø)

@giancarloromeo giancarloromeo changed the title WIP: Upgrade clusters keeper service (Pydantic v2) Upgrade clusters keeper service (Pydantic v2) Oct 11, 2024
@giancarloromeo giancarloromeo marked this pull request as ready for review October 11, 2024 13:51
@giancarloromeo giancarloromeo requested review from GitHK, matusdrobuliak66, pcrespov and sanderegg and removed request for sanderegg October 11, 2024 13:51
pcrespov
pcrespov approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@giancarloromeo giancarloromeo merged commit 42c0a68 into ITISFoundation:pydantic_v2_migration Oct 14, 2024
54 of 58 checks passed
@giancarloromeo giancarloromeo deleted the is4481/upgrade-cluster-keeper branch October 14, 2024 09:16
@giancarloromeo giancarloromeo mentioned this pull request Oct 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitHK GitHK GitHK approved these changes

@pcrespov pcrespov pcrespov approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@sanderegg sanderegg Awaiting requested review from sanderegg

Assignees

@giancarloromeo giancarloromeo

Labels

t:maintenance Some planned maintenance work

Projects

None yet

Milestone

MartinKippenberger

Development

Successfully merging this pull request may close these issues.

4 participants

@giancarloromeo @GitHK @pcrespov @matusdrobuliak66